-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BP-1.10][FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change #11604
Conversation
The JobManagerLeaderListener used by the JobLeaderService was not thread safe. Stopping the listener while notifying a new leader could lead to an IllegalStateException where the rpcConnection which was supposed to be started was concurrently closed by the stop call. This closes apache#11313.
…hen target loses leadership Clearing the rpcConnection field in the JobManagerLeaderListener when target loses leadership prevents that we try to reconnect to the target in case JobLeaderService.reconnect(JobID) is called. This closes apache#11552.
…er under leader change This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change. This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership. Moreover, it only restarts a connection attempt if the leader session id is new.
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 7abc228 (Wed Apr 15 11:39:28 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
Merging this PR since the original PR has been approved. |
…er under leader change This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change. This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership. Moreover, it only restarts a connection attempt if the leader session id is new. This closes #11604.
Merge manually |
This PR is a backport of #11603, #11552 and #11313 onto
release-1.10
.